Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct error message when CREATE TABLE under system databases #29492

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

haolinw
Copy link
Contributor

@haolinw haolinw commented Jan 6, 2025

Description

Previously, if create/drop table under system databases such like:

create table information_schema.ins_test (ts timestamp, c1 int);
drop table information_schema.ins_users;

It reported "Vnode is closed or removed" which was hard to understand
for users. The patch changes it to more meaningful message such like
"Cannot create/drop table of system database..." for better user experience.

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@haolinw haolinw force-pushed the fix/main/TD-33450 branch from d27e501 to 35ac04e Compare January 6, 2025 11:54
@haolinw haolinw changed the title fix: disallow CREATE TABLE under system databases fix: correct error message when CREATE TABLE under system databases Jan 6, 2025
@haolinw haolinw force-pushed the fix/main/TD-33450 branch 4 times, most recently from aac0d47 to 6961cb3 Compare January 7, 2025 07:04
@haolinw haolinw force-pushed the fix/main/TD-33450 branch from 6961cb3 to da76034 Compare January 7, 2025 11:33
@guanshengliang guanshengliang merged commit 2064bd1 into main Jan 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants